Disable NodeReuse by default (FAKE 4) #1600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for NodeReuse was a bit arbitrary, as it only considered TeamCity, TFS and Jenkins. As we were experiencing problems with NodeReuse on GitLab as well, I suggest to disable this for alle build servers (=> only enable for local builds).
Most likely, environments like AppVeyor, where a new instance is created per build job don't have a problem with this, but as they have so many things being run anyway, I would not expect a measurable performance penalty.
Please gibe any comments if this is acceptable or what else would be to consider. If this is accepted, shall I prepare a PR for the v5/master branch as well?