Add support for custom proxy credentials using the same policy as adopted by Paket #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthid
reviewed
Dec 15, 2017
src/app/FakeLib/Utils.fs
Outdated
| @@ -0,0 +1,97 @@ | |||
| [<AutoOpen>] | |||
|
Thanks looks good, only the |
|
You are welcome. I have updated the PR to address the review comments. |
|
Thanks |
|
You are welcome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same policy as adopted by Paket for proxy handling. In case there is a need to declare a custom proxy, use HTTP_PROXY/HTTPS_PROXY in the command line.
Code for proxy handling and memoization taken from Paket
Aims to fix #1660