[1933] Fix: nuget source handling is broken #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why WIP, this looks ready? |
|
Because I haven't tested it. Are you confident in your CI? Otherwise I'll do a manual test tomorrow. |
|
Or if you think the code looks good, pull it :) |
|
Well I'm not so confident for every module (especially nuget) but we have a staging environment which will be deployed once I click merge ;) |
|
thanks! Soon you can just test with staging ;) |
0x53A
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I put this against
release/rcbecause I based it on your changes, feel free to change to master or whatever)