Seperate runInternal & handle error #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlythMeister
force-pushed
the
TargetContext
branch
from
ff90059
to
052414e
Compare
Update returning of context objects to allow for stepping into process
BlythMeister
force-pushed
the
TargetContext
branch
from
052414e
to
a6384b2
Compare
matthid
reviewed
Oct 11, 2018
| @@ -652,6 +652,11 @@ module Target = | |||
| |> Observable.subscribe (fun _ -> Environment.Exit 1) | |||
| Process.killAllCreatedProcesses() |> ignore | |||
| cts.Cancel() | |||
|
|
|||
| /// Optional `TargetContext` | |||
| type OptionalTargetContext = | |||
There was a problem hiding this comment.
Because it is returned, it can't be
matthid
previously approved these changes
Oct 12, 2018
help/markdown/core-targets.md
Outdated
|
|
||
| // *** Start Build *** | ||
| Target.runOrDefaultAndGetContext "Deploy" //Could also use: Target.runAndGetOptionalContext "Deploy" | ||
| |> Target.raiseIfErrorOption |
There was a problem hiding this comment.
raiseIfError as there is no raiseIfErrorOption?
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to the way targets are triggered (non-breaking) to allow for context to be returned and then raiseError called with the context.
Currently, if the context has errors, you do not get the context back.
Another benefit is to allow for stepping into process (more on this later 😉)