Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unintentional unit return #2534

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Fix unintentional unit return #2534

merged 2 commits into from
Aug 5, 2020

Conversation

objectx
Copy link
Contributor

@objectx objectx commented Jul 4, 2020

Description

CreateProcess.warnOnExitCode has a string -> CreateProcess<unit> -> CreateProcess<unit> signature. This is too restrictive.

@objectx
fix: Fix too restrictive function signature
e84edd9 
Unintentionally inferred as `string -> CreateProcess<unit> -> CreateProcess<unit>`
@objectx
fix: Correct eprintf argument
bc6e8c4 
`e` was unused.
@matthid matthid merged commit 0c811b1 into fsprojects:release/next Aug 5, 2020
@matthid
Copy link
Member

matthid commented Aug 5, 2020

Thanks for taking care of this.

@objectx objectx deleted the fix/unintentional-unit-return branch August 5, 2020 12:38
@matthid matthid mentioned this pull request Aug 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@objectx @matthid