Remove Microsoft.SqlServer.SqlManagementObjects from the fakemodule group on paket.dependencies
#2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Tests pass |
xperiandri
changed the title
Microsoft.SqlServer.SqlManagementObjects from the fakemodule group on paket.dependencies
…roup on paket.dependencies
xperiandri
force-pushed
the
sql_dep_2
branch
from
8ce5f7f
to
6a1ace0
Compare
xperiandri
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I don't know any history about these dependencies, so this is just anothet observation:
paket.dependencies has a reference to
Microsoft.SqlServer.SqlManagementObjects.However, I don't see that attached to any of the projects.
Looking at the change history in that area, it looks like the reference was added in #2074 as part of a module update for Fake 5, but according to
FAKE/docs/articles/fake-v6-release-announcement.md
Line 1070 in b658df4
The
Fake.Sql.SqlPackagelibrary that is mentioned as a replacement doesn't seem to reference any of these SQL libraries directly.So - I wonder if the reference here was just left behind when the consumers were removed?
Reason for asking is that there is a substantial dependency chain which includes some old libraries with known CVEs (e.g. Microsoft.Data.SqlClient 4.0), and if it is unused then removing it removes a substantial amount of things from paket.lock.