FAKE.Deploy WorkDirectory fix #461 #520
Conversation
| | true, _ -> | ||
| let exeLocation = typedefof<FakeDeployService>.Assembly.Location | ||
| let directory = IO.Path.GetDirectoryName(exeLocation) | ||
| directory @@ path |
There was a problem hiding this comment.
why not simply use IO.Path.GetFullPath?
There was a problem hiding this comment.
When you install Fake.Deploy as Windows service your CurrentDirectory will be C:\Windows\system32. So if you have relative path in WorkDirectory variable, IO.Path.GetFullPath returns path relative from C:\Windows\system32 what is not intuitive.
I am sure that Fake.Deploy should operates identically in both modes (console & windows service).
There was a problem hiding this comment.
I get your point.
Also with GetFullPath Fake.Deploy would operate identically in both modes, as it doesn't change the program logic depending on the mode.
But for ease of use I would also go with the suggested functionality. It should only be well documented.
There was a problem hiding this comment.
Sorry, but I do not understand... Could you explain?
Path.GetFullPath method uses current directory and current volume information to fully qualify path.
So, the result is depend on current directory which is different for our cases.
Or you suggest to temporary change Environment.CurrentDirectory property to exeLocation?
There was a problem hiding this comment.
No, I mean the application operates also consistently with GetFullPath as in either mode, console or windows service, it depends on current directory.
With your suggestion it depends on executable directory. Also consistently in both modes.
FAKE.Deploy WorkDirectory fix #461
No description provided.