Add HipChat notification helper #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "notify", Convert.ToInt32(param.Notify).ToString() | ||
| "color", param.Color | ||
| "format", "json"] | ||
| |> List.map(fun (key, value) -> key + "=" + HttpUtility.UrlEncode(value)) |
There was a problem hiding this comment.
If this is the only reason to reference System.Web, could you use Uri.EscapeDataString() instead?
There was a problem hiding this comment.
Fair point, that should work too. Are there plans to update FAKE to .NET 4.5? If so, WebUtility.UrlEncode() would work as well.
forki
added a commit
that referenced
this pull request
Aug 25, 2014
|
We try to keep the .NET dependency as low as possible. Thanks for your contribution - it's released with 3.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new helper for sending notifications to HipChat rooms