Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wix Helper Improvements #815

Merged
merged 4 commits into from
May 26, 2015

Conversation

DigitalFlow
Copy link
Contributor

Added tests for WiX Helper methods, fixed a bug and replaced some enum style properties to F# enums with XML commentary for easing usage.

@forki
Copy link
Member

forki commented May 26, 2015

wow. cool stuff

@DigitalFlow
Copy link
Contributor Author

You're welcome, I'm happy to contribute.
Shall I rebase before you merge?

forki added a commit that referenced this pull request May 26, 2015
@forki forki merged commit 1705c8d into fsprojects:develop May 26, 2015
@forki
Copy link
Member

forki commented May 26, 2015

you send PR to develop branch.
Please try master the next time

@DigitalFlow
Copy link
Contributor Author

Alright, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants