Better user input helper #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously getUserInput wasn't generating a new line after the prompt but getUserPassword was doing it. The behavior is now unified.
The prompt now display in white while the value entered by the user is gray (as before).
This fixes a few bugs and added a features : * In the previous code backspace moved back in the input but didn't remove the previous character from screen. * Backspace could move before the starting point of the text, visually erasing the prompt. It is now impossible. * The feature is that password prompts now give a visible feedback in the form of '*' characters instead of nothing.
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using the
UserInputHelperand noticed a few problems and I also couldn't resist adding a few features.Bugs fixed :
the previous character from screen.
erasing the prompt. It is now impossible.
getUserPassword was doing it. The behavior is now unified (They both generate one)
Features added
gray (as before).
form of '*' characters instead of nothing.