Issue 929: #931
Merged
Issue 929: #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder in which targets were actually executed.
|
thx for the fast fix! |
|
Awesome, thx for fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous commit attempted to use the same ordering algorithm (determineBuildOrder) for both serial and parallel builds. The ordering was self-consistent, but was not the same as the ordering reported by PrintDependencyGraph.
I restored the earlier behavior of using determineBuildOrder function only for parallel builds, and the order targets are executed in serial builds now matches that reported by PrintDependencyGraph