Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegistryHelper #976

Merged
merged 2 commits into from
Oct 13, 2015
Merged

RegistryHelper #976

merged 2 commits into from
Oct 13, 2015

Conversation

lulu-berlin
Copy link
Contributor

Here are some additional registry function, as per #966.

I think the function createRegistrySubKey should be changed to follow the pattern of the other ones, but I didn't want to change the API without consulting.

It should:

  1. use the key, since it's an IDisposable
  2. have a signature with baseKey, subKey and keyName.

Additional cleanup should include renaming keyName to valueName or value in setRegistryValue and deleteRegistryValue.

1. deleteRegistrySubKey
2. getRegistryValueNames
3. getRegistrySubKeyNames

- The function valueExistsForKey now uses getRegistryValueNames
@lulu-berlin lulu-berlin changed the title Registry helper RegistryHelper Oct 13, 2015
forki added a commit that referenced this pull request Oct 13, 2015
@forki forki merged commit 4957a10 into fsprojects:master Oct 13, 2015
@forki
Copy link
Member

forki commented Oct 13, 2015

thx. can you send another PR for the additional fixes? But please keep API backwards compatible.

@lulu-berlin
Copy link
Contributor Author

You're welcome, @forki.
I'll send another PR with some cleanup.

As for the API-changing fix, I still think it would make sense to change the signature of createRegistrySubKey. Should I open an issue? Could this be put on hold until the next MAJOR version change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants