Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing kwargs injection on put calls #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodrigoberriel
Copy link

While #392 was supposed to fix #294, it did not. When uploading a file using fs.put, kwargs is still not being forwarded, because these calls are passed to _put_file which does not rely on _pipe, unlike write_* calls.

This PR is very simple: also injects kwargs on bc.upload_blob for the _put_file calls.

@rodrigoberriel
Copy link
Author

rodrigoberriel commented Apr 25, 2024

@TomAugspurger would you mind to consider merging this one for some of the next releases?

Without it, if someone wants to use put and, for instance, set tags and content-type for the blob, the user would have to issue two additional requests (set_blob_tags and set_http_headers) which adds latency and incurs in additional logging costs. I don't know if there's a workaround, but we currently have to rely on a internal fork only because of this simple change.

If the change is too small or you need anything else, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set blob Content-Type in AzureBlobFileSystem.put()
1 participant