helm-values idea plugin deadlock on IntelliJ IDEA 2022.3.2

[gsaukov]

Hi!

Intellij IDEA constantly hangs (i suspect during index scan) after some time of usage of a large project. Disabling the plugin solves the issue.
It seems like it was not reproducible with previous IDEA 2021.
threadDump-20230221-115555.txt

Intellij IDEA Build #IU-223.8617.56, built on January 26, 2023
Runtime version: 17.0.5+1-b653.25 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Apple M1 Max Mac OS Ventura 13.1

[gsaukov]

Perhaps this happens due to symlink ref.
Based on info from Mostafa Nagib from IDEA plugin review page.

[fstaudt]

Hello @gsaukov

thanks for reporting the issue, I'll look into it.

Do you have an example of large project (preferably open source) where the issue can be reproduced ?

Could you also provide more info on usage of symlink refs in helm charts?
Feedback provided in plugin review page was unclear.

Thx in advance !

[gsaukov]

Hi @fstaudt,

I have tried to reproduce this bug with symlink and some of my private project but i could not.
Unfortunately I cannot share the project that has the issue with you or provide much details about because it is corporate project and I'm not allowed to share it.

So perhaps it is a false positive error.

You may close the bug or keep it open so someone can add details or steps to reproduce.
Ssorry for any inconvenience.

[fstaudt]

@gsaukov ,

I've made some performance improvements on JsonSchema providers with release 0.6.1.

Please let me know if latest version of the plugin has improved the situation on your side.
If there is any information that you can share about your project that could help me track the issue, please let me know.

[gsaukov]

@fstaudt
Hi, it is still 0.6.0 in Idea's market place.

[fstaudt]

@gsaukov

release 0.6.1 was done yesterday in github.

It takes a few days to be available for update.

[gsaukov]

Hi @fstaudt

Same thing 0.6.1, it crashes almost immediately on idea start.

The project that crashes is SAP commerce, it is very large JAVA monolith.
You may find IDEA log and thread dump in the attachment. However it is possible that my Idea configuration or some other conditions are very unique. But when I disable helm-values plugin, it does not crash at all.

IDEALOG_AND_THREAD_DUMP.txt

[fstaudt]

Hello @gsaukov ,

does your project contain any Helm chart ?

Performance improvements in 0.6.1 were focused on background tasks performed by the plugin when IDE is already running.
I had the understanding that issues on your project only happened after some time of usage.

A crash at startup can only be caused by JSON schema provider factory in helm-values plugin.
The factory searches the complete repository to find directories containing a file named Chart.yaml.
For large projects containing a lot of files and subdirectories, I imagine it can take a lot of time.
Inspection at startup could be limited to the first level of directories to improve performance and possibly avoid a crash.

I can create a SNAPSHOT version of the plugin with a fix that you can test on your project.
Would you be OK to test a SNAPSHOT version of the plugin on your project ?