Add support for parsing LuaJIT-specific number suffixes #57
Conversation
| @@ -889,6 +889,52 @@ | |||
| }; | |||
| } | |||
|
|
|||
| function scanLuaJITImaginaryUnitSuffix() { | |||
There was a problem hiding this comment.
Nit: other scan* function return AST nodes. This one merely a partial token. The prefix should have been read.
| } | ||
| } | ||
|
|
||
| function scanLuaJITInt64Suffix() { |
| (foundBinaryExponent && foundInt64Suffix) || | ||
| (foundBinaryExponent && foundImaginaryUnit) || | ||
| (foundImaginaryUnit && foundInt64Suffix) | ||
| ) { |
There was a problem hiding this comment.
Seems a bit convoluted. Why not attempt to scan the suffix and return early?
| } | ||
| ] | ||
| }, | ||
| }, |
There was a problem hiding this comment.
It seems you've forgotten to commit the corresponding scaffolding file (test/scaffolding/literals).
There was a problem hiding this comment.
I wrote this by hand 😅 didn't know about the scaffolding system. I'll fix it
There was a problem hiding this comment.
Well, to be fair, the README should have probably mentioned this...
| return true; | ||
| } else { | ||
| // UL but no L | ||
| raise({}, errors.malformedNumber, input.slice(tokenStart, index)); |
There was a problem hiding this comment.
Maybe the function could return the prefix encountered, if any; this information could be then attached to the final AST node.
There was a problem hiding this comment.
Plus, the triply nested if statements look rather ugly.
|
I haven't worked on this in ages so I'm gonna close it |
fstirlitz
added
the
enhancement
This adds support for parsing LuaJIT-specific number suffixes when
options.luaVersionis'LuaJIT'.See http://luajit.org/ext_ffi_api.html#literals for more info.