This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add CorrectUmis to dagr tasks #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
=======================================
Coverage 91.95% 91.95%
=======================================
Files 31 31
Lines 1156 1156
Branches 65 65
=======================================
Hits 1063 1063
Misses 93 93Continue to review full report at Codecov.
|
nh13
suggested changes
Sep 20, 2019
| buffer.append("-i", in) | ||
| buffer.append("-o", out) | ||
| rejects.foreach {r => buffer.append("-r", r) } | ||
| metrics.foreach {M => buffer.append("-M", M) } |
There was a problem hiding this comment.
no capital case variables (unless they're static)
|
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CorrectUmisfromfgbiodoesn't have a correspondingdagrtask. This PR adds that task.Preliminary tests indicate this task works for my purposes, so I'm happy.
Two open questions for this PR:
dagris a bit inconsistent, I used theFilterConsensusReadsstyle just because it was a nice guide for all the features I wanted to use. Let me know if you want to use a different style here.dagrtasks. Let me know if you want to start adding scaladoc.