This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
PicardTask to use the Intel inflater/deflater only if it is safe, by default #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 91.55% 91.56% +0.01%
==========================================
Files 31 31
Lines 1184 1186 +2
Branches 81 81
==========================================
+ Hits 1084 1086 +2
Misses 100 100
Continue to review full report at Codecov.
|
nh13
suggested changes
Oct 8, 2019
|
@clintval this should be unblocked given fulcrumgenomics/commons#59 is merged. |
clintval
force-pushed
the
cv_smarter_deflater_choices
branch
from
b403bfd
to
b21249d
Compare
|
@nh13 all set. Is TravisCI no longer enabled in this repository? |
|
Re-opening to see if I can get travis-ci to build. |
|
@clintval looks like it wasn't triggering, re-opening did the trick |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of my Dagr pipelines now require the Intel Inflater/Deflater to be conditionally turned off across all executables that use htsjdk because of Intel-HLS/GKL#101. Can we intelligently use the Intel Inflater/Deflater, or not, on any Picard task as a default?
Followup to: #367 (including your comment) and fulcrumgenomics/fgbio#534
Note: None of my recent PRs provide parameterization, or default-setting, for GATK tasks!
I have tested this using pipelines that have Picard tasks and confirm it works as expected!