This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Bugfix/nested non unit tasks #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Note: this commit shows the bug Currently, a task that returns an empty task (`EmptyTask` via its `getTasks` method would be stuck in the "ready" state. It is not a `UnitTasks` so isn't scheduled and executed, but it is also not an `EmptyTask` so isn't considered "running".
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 91.56% 91.47% -0.10%
==========================================
Files 31 31
Lines 1186 1185 -1
Branches 80 80
==========================================
- Hits 1086 1084 -2
- Misses 100 101 +1
Continue to review full report at Codecov.
|
tfenne
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tfenne a very interesting edge case I hit in the real world