Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Allow callers of Var2VcfValid to turn on printing of a variant's END tag #398

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

clintval
Copy link
Member

@clintval clintval commented Sep 7, 2021

Do you know why historically this was hardcoded to false?

@codecov-commenter
Copy link

Codecov Report

Merging #398 (3f9ea4d) into master (f639abd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files          31       31           
  Lines        1187     1187           
  Branches       83       83           
=======================================
  Hits         1085     1085           
  Misses        102      102           
Flag Coverage Δ
unittests 91.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f639abd...3f9ea4d. Read the comment docs.

Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know why it was set to false previously. @tfenne do you recall? VarDictJava has evolved quite well over the years, so it could have been an issue there, or the fact we were looking only at small variants?

@nh13 nh13 merged commit d4abcdd into fulcrumgenomics:master Sep 7, 2021
@clintval clintval deleted the cv_end_tag branch September 7, 2021 16:29
@clintval
Copy link
Member Author

clintval commented Sep 7, 2021

To follow up. I have non-exhaustively tested VarDictJava's ability to correctly calculate the END tag on a large collection of simple variants (SNV, MNV, insertion, deletion) and on simple symbolics (INS, INV, DUP). Given that downstream tooling wants the END tag for symbolics, it is a good idea to include it:

• END : end position of the variant described in this record (for use with symbolic alleles)

Source: https://samtools.github.io/hts-specs/VCFv4.2.pdf

Thank you for the merge!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants