Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support PEP604 syntax str | None #168

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support PEP604 syntax str | None #168

wants to merge 2 commits into from

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jul 19, 2024

Fixes #89

nh13
nh13 commented Jul 19, 2024
View reviewed changes
fgpyo/util/types.py Outdated Show resolved Hide resolved
nh13
nh13 commented Jul 19, 2024
View reviewed changes
tests/fgpyo/util/test_types.py Outdated Show resolved Hide resolved
@nh13 nh13 temporarily deployed to github-actions-ci July 19, 2024 18:07 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 19, 2024 18:07 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 19, 2024 18:07 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 19, 2024 18:07 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 19, 2024 18:07 — with GitHub Actions Inactive
@nh13 nh13 requested a review from msto July 19, 2024 18:08
@nh13 nh13 marked this pull request as ready for review July 19, 2024 18:09
@nh13 nh13 requested a review from tfenne as a code owner July 19, 2024 18:09
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.99%. Comparing base (57f13cc) to head (07a797c).

Files Patch % Lines
fgpyo/util/types.py 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   89.02%   88.99%   -0.04%     
==========================================
  Files          17       17              
  Lines        2005     2017      +12     
  Branches      437      439       +2     
==========================================
+ Hits         1785     1795      +10     
- Misses        144      145       +1     
- Partials       76       77       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfenne
Copy link
Member

tfenne commented Jul 22, 2024

I don't think I know enough to review this well, so will rely on @msto.

@nh13
Copy link
Member Author

nh13 commented Jul 30, 2024

@msto bump

@msto msto self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msto msto Awaiting requested review from msto

@tfenne tfenne Awaiting requested review from tfenne tfenne is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@msto msto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric.read should support PEP 604 syntax for Optional types
3 participants
@nh13 @tfenne @msto