Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds classes and methods for sequence dictionaries #160

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Jul 15, 2024

Fixes #152

@nh13 nh13 requested a review from tfenne as a code owner July 15, 2024 04:27
@nh13 nh13 force-pushed the feature/sequence-dictionary branch from f245503 to 7fc27d8 Compare July 15, 2024 04:29
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 04:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 04:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 04:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 04:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 04:29 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 93.92523% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (2261825) to head (408fec4).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
fgpyo/fasta/sequence_dictionary.py 93.92% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
+ Coverage   88.44%   89.02%   +0.58%     
==========================================
  Files          16       17       +1     
  Lines        1791     2005     +214     
  Branches      381      437      +56     
==========================================
+ Hits         1584     1785     +201     
- Misses        136      144       +8     
- Partials       71       76       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly 👍 but with a few thoughts/questions.

fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Show resolved Hide resolved
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 19:36 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 19:36 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 19:36 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 19:36 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 15, 2024 19:36 — with GitHub Actions Inactive
@nh13 nh13 requested a review from tfenne July 15, 2024 20:24
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 12:37 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 12:37 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 12:37 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 12:37 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 12:37 — with GitHub Actions Inactive
@nh13 nh13 force-pushed the feature/sequence-dictionary branch from 5079331 to 62d3e42 Compare July 16, 2024 15:23
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 15:23 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 15:23 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 15:23 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 15:23 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 15:23 — with GitHub Actions Inactive
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comment, but good to go.

fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
fgpyo/fasta/sequence_dictionary.py Outdated Show resolved Hide resolved
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:29 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:29 — with GitHub Actions Inactive
@nh13 nh13 force-pushed the feature/sequence-dictionary branch from ddbb2f6 to 408fec4 Compare July 16, 2024 18:40
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:40 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:40 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:40 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:40 — with GitHub Actions Inactive
@nh13 nh13 temporarily deployed to github-actions-ci July 16, 2024 18:40 — with GitHub Actions Inactive
@nh13 nh13 merged commit dfcb7e2 into main Jul 16, 2024
6 checks passed
@nh13 nh13 deleted the feature/sequence-dictionary branch July 16, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: better modeling of a pysam sequence dictionary
2 participants