Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about TemporalSelfAttention #272

Open
usergxx opened this issue Jul 30, 2024 · 0 comments
Open

Question about TemporalSelfAttention #272

usergxx opened this issue Jul 30, 2024 · 0 comments

Comments

@usergxx
Copy link

usergxx commented Jul 30, 2024

TemporalSelfAttention does not address the issue of extracting indices from value based on query. There is still flaw here.

During training mode, in the TemporalSelfAttention module, the generation of the first frame's query takes the previous frame's value. However, this value is the original query without encoding. Therefore, the historical queries of the first frame actually lack positional encoding. Shouldn't they be added?
20240730-102648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant