Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift 4.2.1 / Xcode 10.1 #1

Merged
merged 15 commits into from
Jan 21, 2019
Merged

Support for Swift 4.2.1 / Xcode 10.1 #1

merged 15 commits into from
Jan 21, 2019

Conversation

RomanPodymov
Copy link
Contributor

Good evening.
Thank you for this library, it is very interesting.
I added support of Swift 4.2.1 / Xcode 10.1. I fixed some warnings. Tested the example on a device with iOS 12.1.1 and it looks good.

@mkj-is mkj-is requested a review from a team January 14, 2019 13:46
@mkj-is
Copy link
Contributor

mkj-is commented Jan 14, 2019

Sorry we did not make the review sooner, but you forgot to add anyone to reviewers.

// Override point for customization after application launch.
return true
}

func applicationWillResignActive(application: UIApplication) {
func applicationWillResignActive(_ application: UIApplication) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as in your LocationManager PR, feel free to delete these generated methods.

futuredapp/LocationManager#9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkj-is Done.

@RomanPodymov
Copy link
Contributor Author

RomanPodymov commented Jan 16, 2019

Sorry we did not make the review sooner, but you forgot to add anyone to reviewers.

@mkj-is I don't have such permissions, but I hope that I will receive them soon.

@mkj-is mkj-is requested a review from a team January 18, 2019 09:38
@mkj-is mkj-is merged commit f36a49b into futuredapp:master Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants