Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage flow broken #119

Closed
aneels3 opened this issue Oct 27, 2021 · 4 comments
Closed

Coverage flow broken #119

aneels3 opened this issue Oct 27, 2021 · 4 comments

Comments

@aneels3
Copy link
Contributor

aneels3 commented Oct 27, 2021

Hi @mballance
While running any coverage related tests, I am getting below ModuleNotFoundError error.

Traceback (most recent call last):
  File "wildcard.py", line 1, in <module>
    import vsc
  File "/home/anil/.local/lib/python3.6/site-packages/vsc/__init__.py", line 37, in <module>
    from vsc.coverage import *
  File "/home/anil/.local/lib/python3.6/site-packages/vsc/coverage.py", line 53, in <module>
    from attr.filters import exclude
ModuleNotFoundError: No module named 'attr'

The import statement is being added in the recent release of the PyVSC from attr.filters import exclude

I can see, you are not using exclude anywhere in the coverage.py file.
I tried commenting the import statement and the test worked as expected.

Is this required for illegal and ignore bins implementation?
Can you take a look at this?

Thanks

@mballance
Copy link
Member

Thanks, @aneels3. Of course, I'll have a look. I'm actually a bit surprised that the CI build/test passed. What version of Python are you using?

@aneels3
Copy link
Contributor Author

aneels3 commented Oct 27, 2021

I have Python 3.6.8 installed.

mballance added a commit that referenced this issue Oct 28, 2021
- (#119) Correct accidental import of attr.exclude

Signed-off-by: Matthew Ballance <[email protected]>
@mballance
Copy link
Member

mballance commented Oct 28, 2021

Hi @aneels3, this has been fixed in the 0.6.2 release. Thanks for finding and reporting this!

@aneels3
Copy link
Contributor Author

aneels3 commented Oct 28, 2021

Thanks @mballance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants