-
Notifications
You must be signed in to change notification settings - Fork 17
runYarn fails on Windows 10 #20
Comments
Thanks for reporting. I haven't been able to test on Windows before. A few ideas:
|
Do you think that this should be using |
It should be using `@nodejs://:yarn`, the priority is consistency across
developers of a team. I didn't realise it wasn't the case!
|
I just tried it out and I think that I was wrong. It seems to be using |
It's indeed not obvious. The key is that See also the documentation at https://docs.bazel.build/versions/master/skylark/lib/actions.html#run |
I was able to get past the caching issue by resolving the cache path (see this commit). But now I am running into this error (still on windows):
|
I think Node and/or Windows' shell might be confused by the |
Is that supposed to be expanded somehow before going to |
No, it's put into a // Copy source code.
for (const src of srcs) {
if (!src) {
continue;
}
if (!fs.existsSync(src)) {
console.error(`
Missing file ${src} required by ${targetLabel}.
`);
process.exit(1);
}
const destinationFilePath = path.join(destinationDir, src);
safeSymlink(src, destinationFilePath);
} |
I think that this is a problem with the sources that are joined with
I get a similar error:
|
Nice find. Let's use another separator?
|
I'm working on wrapping the arguments with quotes. If I do that windows will leave it alone. The scripts need to be changed a little though, because in windows the shell doesn't consume the quotes, it passes them through. |
@fwouts So I probably pulled more threads than I should have on this one. But in researching Also, apologies if some of this stuff is a little incomplete. Still very much a WIP and your feedback is appreciated. |
What do you mean by a "param file"? Either way, the JsContext provider seems like a good idea! It sounds like it would be useful on its own as a first PR to clean up the existing code? |
The Args.use_param_file() option allows args objects created by And yeah, I should probably break this work into a set of smaller PRs. |
I have been able to reproduce this on two Windows 10 systems so far attempting to build the same project. The project works on a mac.
When running the build the following error occurs:
I checked manually and
C:\\users\\admin\\_bazel_admin\\wjqdalcp\\execroot\\services_core\\node_modules_cache\\v1\\npm-babel-runtime-6.26.0-965c7058668e82b55d7bfe04ff2337bc8b5647fe\\core-js\\reflect\\get-metadata-keys.js
does exist.Versions
I am going to keep trying to figure out how to fix this, but any pointers are appreciated.
The text was updated successfully, but these errors were encountered: