Compilation warnings about abs()

[kankaristo]

I'm getting some compilation warnings from glm/detail/func_trigonometric.inl:

In file included from Debug/swig_glm_wrap.cxx:2805:
In file included from ../thirdparty/glm/glm.hpp:108:
In file included from ../thirdparty/glm/gtc/../trigonometric.hpp:32:
In file included from ../thirdparty/glm/detail/func_trigonometric.hpp:199:
../thirdparty/glm/detail/func_trigonometric.inl:209:92: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
                return (x < genType(0) ? genType(-1) : (x > genType(0) ? genType(1) : genType(0))) * log(abs(x) + sqrt(genType(1) + x * x));
                                                                                                         ^
Debug/swig_glm_wrap.cxx:106894:24: note: in instantiation of function template specialization 'glm::asinh<float>' requested here
  result = (float)glm::asinh((float const &)*arg1);
                       ^
../thirdparty/glm/detail/func_trigonometric.inl:209:92: note: use function 'std::abs' instead
                return (x < genType(0) ? genType(-1) : (x > genType(0) ? genType(1) : genType(0))) * log(abs(x) + sqrt(genType(1) + x * x));
                                                                                                         ^~~
                                                                                                         std::abs
../thirdparty/glm/detail/func_trigonometric.inl:239:6: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
                if(abs(x) >= genType(1))
                   ^
Debug/swig_glm_wrap.cxx:107236:24: note: in instantiation of function template specialization 'glm::atanh<float>' requested here
  result = (float)glm::atanh((float const &)*arg1);
                       ^
../thirdparty/glm/detail/func_trigonometric.inl:239:6: note: use function 'std::abs' instead
                if(abs(x) >= genType(1))
                   ^~~
                   std::abs
2 warnings generated.

The above warnings are from Clang on OS X, but I think I remember seeing them on some other platform as well.

Like the warning message suggests, changing abs(x) to std::abs(x) seems to fix this.

[Groovounet]

Hi,

I applied your proposed fix on both 0.9.7 and master branches.

Thanks for reporting!
Christophe

[kankaristo]

Thanks, that was fast!

There was a second warning in the same file for atanh() (line 239).

[Groovounet]

Fixed! :)