-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Build directory spdlogConfigTargets.cmake
doesn't provide a spdlog::spdlog_header_only
target
#2678
Comments
In addition by not exporting the export called with target "use_spdlog" which requires target "spdlog_header_only"
that is not in any export set. |
@robertmaynard Thanks for reporting. PR to fix this would be most welcome. |
@robertmaynard Any chance you send PR for this before next release (few days)? |
robertmaynard
added a commit
to robertmaynard/spdlog
that referenced
this issue
Aug 7, 2023
gabime
pushed a commit
that referenced
this issue
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The installed version of
spdlogConfigTargets.cmake
includes both thespdlog::spdlog
andspdlog::spdlog_header_only
targets. The build directory version only provides the compiled library target, which causes issues for dowstream consumers of the header only version.This is caused by a mismatch between what targets are exported via the
install
andexport
commands.Updating line https:/gabime/spdlog/blob/v1.x/CMakeLists.txt#L339 to also include spdlog_header_only would fix this issue.
The text was updated successfully, but these errors were encountered: