-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetCDF Doesn't Support Logical/Boolean Variables so Saving Code Parameters Fails #288
Comments
Perhaps for those variables you could convert the booleans to integers, and then mark the conversion with an attribute (something like |
Note that in OMFIT we go through this rigamarole for exporting to netcdf - https:/gafusion/OMFIT-source/blob/unstable/omfit/omfit_classes/omfit_data.py#L35 - then again when importing from netcdf - https:/gafusion/OMFIT-source/blob/unstable/omfit/omfit_classes/omfit_data.py#L138 . Seems like an opportunity for generalizing the approach into a common set of utilities. |
Stale issue message |
This problem has been around for a while and can be avoided by saving with HDF5 instead, but I'm opening this issue to document the limitation and see if anyone has ideas about whether other solutions could be possible.
NetCDF doesn't support any logical or boolean variable types so an error gets thrown when there's one in the
code.parameters
:It would be possible for OMAS to convert these to integers {0,1} before saving to the file, but there wouldn't be any way to know if an integer stored in NetCDF should be converted to a logical variable when read in, since
code.parameters
doesn't have any defined structure.The text was updated successfully, but these errors were encountered: