refactor(build): change setup.py to pyproject.toml and supress cython warning #293
Conversation
| @@ -864,23 +865,6 @@ def omas_global_quantities(imas_version=omas_rcparams['default_imas_version']): | |||
| return _global_quantities[imas_version] | |||
|
|
|||
|
|
|||
| # only attempt cython if effective user owns this copy of omas | |||
| # disabled for Windows: need to add check for file ownership under Windows | |||
| if os.name == 'nt' or os.geteuid() != os.stat(__file__).st_uid: | |||
There was a problem hiding this comment.
With this change the compiled version of omas_cython should be available to everyone. Also windows users.
| exclude = ["sphinx*"] | ||
|
|
||
| [tool.setuptools.dynamic] | ||
| version = {file = "omas/version"} |
There was a problem hiding this comment.
This automatically sets the version to what is found in omas/version
pyproject.toml
Outdated
| ] | ||
| keywords = ["integrated modeling", "OMFIT", "IMAS", "ITER"] | ||
|
|
||
| requires-python = '>=3.8' |
There was a problem hiding this comment.
It would require bumping this from 3.6 to 3.8.
3.6 was end of life in 2021, so I hope that this is ok?
There was a problem hiding this comment.
OMFIT is at python=3.7 and uses omas as an integral part. What changes are you making here that require python>=3.8?
There was a problem hiding this comment.
@smithsp I double checked and I was correct that in theory 3.7 should have been sufficient to enable usage of pyproject.toml based package configurations.
However, the problem here is the dependency on pygacode which is forced to version 0.71 from 2022 because that's the last version that supports 3.7, and that version does not correctly specify its build dependencies (requires numpy). This is fixed for versions >1.0 but those require python >=3.8 which is why the build here works for 3.8 but nor for 3.7.
There was a problem hiding this comment.
We are actively working on migrating OMFIT to a later python version.
|
Stale pull request message |
I was motivated to fix #289, but when starting to work on the old
setup.pyI was curious if you would be open to a bit of a modernisation, see below:Changes in this PR:
pyproject.tomlfollowing the adopted python standards.setup.pythat translatesomas_cython.pyxtoomas_cython.cat the time the sdist package is created. This has the benefit thatCythonis no longer a dependency for users. They*.cfile still gets compiled during package install on the users computer, but that still is pretty quick and doesn't produce any warnings.This PR also removes the need to manually traverse the file hierarchy to create
packagesandpackage_datalists. This is now automatically handled.Editable installs still work by simply running:
To build a sdist package using
buildrun:from the root of the project. This creates an isolated virtual environment to build the sdist according to the spec in
pyproject.toml.