Update to use IMAS 3.40.1 #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like a pretty small change overall. I haven't seen much change in the DD and all tests are still passing. git seems more confused about the update than should be necessary, but the changes were all automated to I'm planning to leave that be. The OMFIT regression tests need to be checked before this is merged.
|
Is there a way to look at why the regression tests failed here? It could be related to #291 but I don't see how to confirm this. All other tests passed when I ran them on Iris so I can deactivate those tests for now if the fixes will be longer term (I can see the last 2 merges did not pass the regression) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a pretty small change overall. I haven't seen much change in the DD and all tests are still passing (both here an for OMFIT).
The PR for updating the OMAS version in OMFIT should be merged after this