Skip to content

Commit

Permalink
feat: drop Node v4
Browse files Browse the repository at this point in the history 
BREAKING CHANGE: Dropped Node v4.
  • Loading branch information
@gajus
gajus committed Mar 18, 2017
1 parent 8f41c17 commit 8c9f89e
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
6 changes: 5 additions & 1 deletion .babelrc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
"add-module-exports"
],
"presets": [
"es2015"
["env", {
"targets": {
"node": "current"
}
}]
]
}
1 change: 0 additions & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ node_js:
- 7
- 6
- 5
- 4
before_install:
- npm config set depth 0
- npm install --global npm@latest
Expand Down
5 changes: 4 additions & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"babel-cli": "^6.18.0",
"babel-plugin-add-module-exports": "^0.2.1",
"babel-plugin-transform-flow-strip-types": "^6.18.0",
"babel-preset-es2015": "^6.5.0",
"babel-preset-env": "^1.2.2",
"babel-register": "^6.18.0",
"chai": "^3.5.0",
"eslint": "^3.10.2",
Expand All @@ -23,6 +23,9 @@
"mocha": "^2.5.3",
"semantic-release": "^6.3.2"
},
"engines": {
"node": ">=5"
},
"keywords": [
"eslint",
"plugin",
Expand Down

4 comments on commit 8c9f89e

@SimenB
Copy link
Contributor

@SimenB SimenB commented on 8c9f89e Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you drop a current LTS, but support EOL 5?

@gajus
Copy link
Owner Author

@gajus gajus commented on 8c9f89e Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you drop a current LTS, but support EOL 5?

Sorry, I cannot remember the reason for it.

This commit looks flawed for multiple reasons, though. ["env", {"targets": {"node": "current"}}] is definitely not right – this will build in whatever version the Travis agent is running.

@gajus
Copy link
Owner Author

@gajus gajus commented on 8c9f89e Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit looks flawed for multiple reasons, though. ["env", {"targets": {"node": "current"}}] is definitely not right – this will build in whatever version the Travis agent is running.

Looks like at least that bit was fixed later.

eslint-plugin-jsdoc/.babelrc

Line 11 in 50d8d23

"node": 5

@gajus
Copy link
Owner Author

@gajus gajus commented on 8c9f89e Apr 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you drop a current LTS, but support EOL 5?

I cannot think of a reason for dropping v4 support in the first place. I've migrated a few projects to require Node +v7.9, but those are dependencies, not devDependencies.

I guess, if this is causing issues @SimenB, please raise a PR to re-enable v4 (including .babelrc).

Please sign in to comment.