Skip to content

Commit

Permalink
build: change min node version to 8.3.0 (ipfs#996)
Browse files Browse the repository at this point in the history
Also adjust Travis CI config to perform builds and tests with node 8.

`npm install`, `npm run build`, and `npm run test` all succeeded locally with
node version `8.3.0`.

The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced
support for object rest/spread, which is used by at least one of this package's
devDependencies (`go-ipfs-dep`). It may be the case that at runtime older
versions of node would work correctly with the built package, but it seems
simpler to settle on the minimum supported version being a version that can
build, test, and use the package.

Closes ipfs#983.
  • Loading branch information
michaelsbradleyjr authored and Alan Shaw committed May 15, 2019
1 parent f4b89ed commit 7a47e3b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ stages:

node_js:
- '10'
- '8'

os:
- linux
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"through2": "^3.0.1"
},
"engines": {
"node": ">=10.0.0",
"node": ">=8.3.0",
"npm": ">=3.0.0"
},
"repository": {
Expand Down

0 comments on commit 7a47e3b

Please sign in to comment.