Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating govmomi to version 28 #31

Merged
merged 3 commits into from
May 11, 2022
Merged

updating govmomi to version 28 #31

merged 3 commits into from
May 11, 2022

Conversation

tuxgoose
Copy link
Contributor

@tuxgoose tuxgoose commented May 11, 2022 •
edited
Loading

What this PR does / why we need it:
Updates the govmomi to the latest version
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Update govmomi code to `v0.28.0`

@tuxgoose tuxgoose requested review from a team as code owners May 11, 2022 18:51
@CLAassistant
Copy link

CLAassistant commented May 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels May 11, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
briantopping
briantopping approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@briantopping briantopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2022
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels May 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 11, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 11, 2022
@tuxgoose tuxgoose merged commit cf2b7ee into main May 11, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 11, 2022
@tuxgoose tuxgoose deleted the govmoi-28 branch May 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantopping briantopping briantopping approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tuxgoose @CLAassistant @briantopping @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot