Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Golang to 1.19.5 #49

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Update Golang to 1.19.5 #49

merged 1 commit into from
Jan 23, 2023

Conversation

briantopping
Copy link
Member

@briantopping briantopping commented Jan 23, 2023 •
edited
Loading

Signed-off-by: Brian Topping [email protected]

What this PR does / why we need it:
Update machine-controller-manager-provider-vsphere Golang to 1.19.5
Release note:

Update machine-controller-manager-provider-vsphere Golang to 1.19.5

@briantopping briantopping requested review from a team as code owners January 23, 2023 13:02
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 23, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 23, 2023
@briantopping
Copy link
Member Author

/lgtm
/ok-to-test

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Jan 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2023
@briantopping
Update Golang to 1.19.5
eb3e3e1 
Signed-off-by: Brian Topping <[email protected]>
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 23, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2023
@briantopping briantopping changed the title Update Golang to 1.19.5, Ginkgo to v2, revendor Update Golang to 1.19.5 Jan 23, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 23, 2023
tuxgoose
tuxgoose approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@tuxgoose tuxgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tuxgoose
tuxgoose approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@tuxgoose tuxgoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@briantopping briantopping merged commit 69aa8d7 into main Jan 23, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 23, 2023
@briantopping briantopping deleted the revendor_1_19_5 branch January 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuxgoose tuxgoose tuxgoose approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@briantopping @tuxgoose @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot