Mark machine failed during rollout also #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A bug where MCM was not marking machine as failed during rollout has been resolved.
In situation where the all the machines in the new or the old machineset go into
Unknown
state , as per the current logic the rollout would stop and won't proceed until we manually delete the machine.This happens because machineSet controller is not aware of a
Unknown
state and so takes no action, and only machine controller could resolve this situation by marking the machineFailed
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
maxReplacement
value, but after looking back , machine were always markedFailed
during rollout previously also , so this PR just kind of goes back to the previous logicRelease note: