Add support for user content type and file content type #276
Conversation
Signed-off-by: soupette <[email protected]>
src/gatsby-node.js
Outdated
|
|
||
| const nodeType = makeParentNodeName(ctx.schemas, uid); | ||
| if (uid === 'plugin::upload.file') { | ||
| for (let file of data[i]) { |
There was a problem hiding this comment.
I'm curious if it would be possible to use parallelization for all these loops? With Promise.all
it could have some positive impact on build time
There was a problem hiding this comment.
We are already doing it for all entities of a content type.
There was a problem hiding this comment.
For the file model it's a bit different I don't want to create children node but just to apply the image processing, I am not even sure we should support it at the moment, it does not really makes sense for query all the files in gatsby.
WDYT about removing it completely?
There was a problem hiding this comment.
I think the previous plugin didn't have it, and I don't remember anyone in the community asking for it. If it requires special treatment (like no query params etc.) we might as well remove I think
There was a problem hiding this comment.
Perfect!
It could always be added later if the community needs it anyway
src/helpers.js
Outdated
| kind, | ||
| uid, | ||
| endpoint: '/api/upload/files', | ||
| queryParams: {}, |
There was a problem hiding this comment.
Is it necessary to block user query params here? I don't know if it's possible today, but at some point we may have images with support for localization or draft & publish
There was a problem hiding this comment.
The API response is not the same for the files and the file model does not create any children node so for the moment I have jsut added the support and I'll let the expansion deal with what you think is best.
| @@ -151,12 +151,13 @@ export const cleanAttributes = (attributes, currentSchema, schemas) => { | |||
| * @param {Object} ctx | |||
| * @returns {Object} | |||
| */ | |||
| export const cleanData = ({ id, attributes }, ctx) => { | |||
| export const cleanData = ({ id, attributes, ...rest }, ctx) => { | |||
There was a problem hiding this comment.
Is this because the /files endpoint doesn't have the v4 response format?
There was a problem hiding this comment.
Yes and similarly for the user content type ....
Signed-off-by: soupette <[email protected]>
soupette
force-pushed
the
fix-users-content-type
branch
from
f50051e
to
f2fb197
Compare
Signed-off-by: soupette [email protected]
Allow to query user content type and file content types.