Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout-render.js doesn't pick up state changes #1756

Closed
craigmulligan opened this issue Aug 10, 2017 · 2 comments · Fixed by #1773
Closed

Layout-render.js doesn't pick up state changes #1756

craigmulligan opened this issue Aug 10, 2017 · 2 comments · Fixed by #1773

Comments

@craigmulligan
Copy link

There seems to be a bug with with the layout state change in dev mode, with sync requires no onPostLoadPageResources is fired which means layouts aren't updated when changing routes.

Quick look at the code and it looks like the emitter isn't emitting the event in dev mode, don't have time to look further right now, but if anyone can confirm that are seeing the same behaviour that'd be useful 👍
@KyleAMathews
Copy link
Contributor

So this is a dev-only problem?

@craigmulligan
Copy link
Author

@KyleAMathews, yip.

@KyleAMathews KyleAMathews mentioned this issue Aug 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ComponentRenderer for both page/layout components gatsbyjs/gatsby
2 participants
@KyleAMathews @craigmulligan