Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatsby Cloud builds should not fail on deprecation warnings #22238

Closed
styxlab opened this issue Mar 13, 2020 · 1 comment
Closed

Gatsby Cloud builds should not fail on deprecation warnings #22238

styxlab opened this issue Mar 13, 2020 · 1 comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby

Comments

@styxlab
Copy link
Contributor

styxlab commented Mar 13, 2020

Description

Deprecation warnings from the Node environment should not lead to failing Gatsby Cloud builds.
Currently gatsby-starter-try-ghost is hit by #18433. As this is only a warning, it should not lead to failing builds on Gatsby Cloud.

Reproduction

Simply try to build a starter affected by #18433, e.g. gatsby-starter-try-ghost on Gatsby Cloud and observe the build logs.

Solution

I'm not sure if this should be solved in the Gatsby Cloud environment or in Gatsby CLI. It seems wrong that Gatsby CLI is issuing an ERROR in case of these warnings. However, when you build locally, the build finishes correctly.

@styxlab styxlab added the type: bug An issue or pull request relating to a bug in Gatsby label Mar 13, 2020
@LekoArts
Copy link
Contributor

Thank you for opening this!

Please contact [email protected] - the repository is not the right place for inquiries about Gatsby Cloud.

We're marking this issue as answered and closing it for now but please feel free to comment here if you would like to continue this discussion. We also recommend heading over to our communities if you have questions that are not bug reports or feature requests. We hope we managed to help and thank you for using Gatsby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

No branches or pull requests

2 participants