Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-sharp): Upgrade sharp #28119

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Conversation

ascorbic
Copy link
Contributor

Upgrade sharp to ^0.26.3. We can do this now that it no longer requires newer node versions. The main benefit for us now is that it adds support for dominant colors, which we use in the new image transformer if it's available

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Nov 17, 2020
@@ -5,7 +5,7 @@ Object {
"aspectRatio": 1,
"height": 20,
"originalName": "test.png",
"src": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAUCAIAAAAC64paAAAACXBIWXMAAAsSAAALEgHS3X78AAABKklEQVQ4y8WUy07DMBBFrwMpr4aybjepUeqIFd/CAgmJsuIHgWXVL+Gx4C3xCdQJnpm0UDJNAQnVuouMM8dzY4+DcoA/C/8Fe9bv4ABMMpQOZc5yFPqfwEUQY499jHoY9/BsKQyTRTNMyzu8WAwTbBnI2DY438XbPr0qFsFCvlrkMTERYFgRL3HYUvh5OMdpQqkbBtPC9NDiINQPCZM6LGVvUzIpwNch4V5EGxHS/DeYtjfHZbcyXB8yGfaPimcafLEMHqmw2L5OsWkUUuY6Ee5V28WUP25TXjwPS3iWUFnfcFQPFna98rlmSGL4IOZucQvgT76Po53qeOTYTtp4qpFKe/qM29PhJsVVl3SXsluntLfS7rPvn10MP1Aau+lKBuA9I/kV/AyW6gNTIWTuA/r8lQAAAABJRU5ErkJggg==",
"src": "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABQAAAAUCAIAAAAC64paAAAACXBIWXMAAAsTAAALEwEAmpwYAAABOklEQVQ4y2P4r8ZANmKgvuZ/agy/VaHojyopmv+CNf/XQCCoCEHNf1VBqv+oM5yVY1giwbBakuG2AkjknzoW/eh2AtWdkWMwZ2cAAkYQwcDCwBDOw/BCGWwELs1wnfxMUJ1MMBIIjNkY3gH1o9qPCCGIfisOkFI2iKUMUFPYwdxcfrCPVDE0/wFbe0QGpIiJAR1AjJJlYXiPajlMMzicpouBFDEz4AQX5KCBj0XzXHECmi/JY9MMCa1zciAXMmLogXhEiYXhqwoigFBCGyLkzQVSBwwhuM+ZYeHXKIQjwKCWqzM8UGRQYUUJNgjDl4vhlxqKtdgSiTrDYyWGGF4GXphucWaGOiGG76rokYw9eQJTItB5L5QYTsqBEulHoD81sSdv7FkK4gRoxlAnOmMgewGSJf/StTAgEgEA1PJk9+Vu8VgAAAAASUVORK5CYII=",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that these images are visually identical

@pvdz pvdz changed the title chore: Upgrade sharp chore(gatsby): Upgrade sharp Nov 17, 2020
@pvdz pvdz added topic: sharp and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Nov 17, 2020
@ascorbic ascorbic changed the title chore(gatsby): Upgrade sharp chore(gatsby-plugin-sharp): Upgrade sharp Nov 17, 2020
@ascorbic ascorbic added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Nov 17, 2020
@gatsbybot gatsbybot merged commit ab96f1e into master Nov 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/upgrade-sharp branch November 17, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants