fix(gatsby-plugin-sharp): use actions provided, don't assume Gatsby module location.

[martin-css]

The gatsby module resolve by require might not be the gatsby module that is executing. This can occur in mono-repo configurations.

This will prevent the Redux store from receiving the job actions and the bootstrap process will complete without waiting for all images to be processed. This can cause the build to finish without all images being generated.

Fixes #9984.

[pieh]

This is a bit problematic: gatsby-plugin-sharp isn't technically a gatsby plugin (it's utility library) - so it wasn't actually needed to put it in gatsby-config plugin section, so this will break when people don't have in gatsby-config.

We should pass actions that are needed to gatsby-plugin-sharp functions (similiar to how reporter and cache is passed). And, at least for now, have fallback to current behaviour if they are not.

[martin-css]

I'm fairly new to Gatsby (started with V2) so I'm not aware of all the history and what could construe a breaking change. All the V2 documentation I remember reading online certainly always instructs that gatsby-plugin-sharp be placed in the plugins section of gatsby-config, for example, gatsby-transformer-sharp.

However, I've amended the pull request to keep the existing functionality in case any user hasn't added to gatsby-config. If gatsby-plugin-sharp is present then it will use the actions passed to the plugin.

Longer term it might be worth refactoring how gatsby-plugin-sharp obtains the bound actions. However, this is a much bigger task and would affect all plugins that depend on gatsby-plugin-sharp, including 3rd party plugins.

This should hopefully now be a non-breaking change that will fix using Gatsby in a mono-repo - as long as plugin is present in gatsby-config as most documentation suggests it should be.

[pieh]

Thanks @martin-css!

[gatsbot]

Holy buckets, @martin-css — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https:/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[pieh]

Longer term it might be worth refactoring how gatsby-plugin-sharp obtains the bound actions. However, this is a much bigger task and would affect all plugins that depend on gatsby-plugin-sharp, including 3rd party plugins.

This should hopefully now be a non-breaking change that will fix using Gatsby in a mono-repo - as long as plugin is present in gatsby-config as most documentation suggests it should be.

Yeah, we will probably want to change it later on, but this will work for now

[pieh]

Published [email protected] with those changes