Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Gatsby V2 project structure #10059

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Use Gatsby V2 project structure #10059

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c1d5a6
Use Gatsby V2 project structure
albertod Nov 21, 2018
100f2c9
Update README.md
albertod Dec 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gatsby-remark-prismjs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ CSS along your PrismJS theme and the styles for `.gatsby-highlight-code-line`:

If you want to add line numbering alongside your code, you need to
import the corresponding CSS file from PrismJS, right after importing your
colorscheme in `layout/index.js`:
colorscheme in `src/components/layout.js`:

```javascript
// layouts/index.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t forget this comment 😛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is my first contribution on this project and I see that you have collaborated before. Is there anything wrong with my PR? Thank beforehand for any feedback.

Copy link
Contributor

@LekoArts LekoArts Nov 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, your proposed change is fine I guess. Just wanted to mention that you also should change the comment inside the codeblock

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertod Do you have time to make that change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

Expand Down