Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): workaround graphql-compose issue #29822

Merged
merged 2 commits into from
Feb 27, 2021

Conversation

vladar
Copy link
Contributor

@vladar vladar commented Feb 27, 2021

Description

We've noticed that the query running step on v3 is pretty slow. After investigation, the issue was discovered in graphql-compose: graphql-compose/graphql-compose#319

This PR is a workaround for it. But the proper fix should be added in graphql-compose itself. Once fixed upstream, we can remove this workaround.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 27, 2021
@vladar vladar added topic: GraphQL Related to Gatsby's GraphQL layer and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 27, 2021
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you @vladar

@sidharthachatterjee sidharthachatterjee merged commit 7f9bcf1 into master Feb 27, 2021
@sidharthachatterjee sidharthachatterjee deleted the vladar/gql-perf-issue branch February 27, 2021 14:53
@nodkz
Copy link

nodkz commented Feb 27, 2021

Screen Shot 2021-02-28 at 01 04 19

I have a plan for how to fix this problem in graphql-compose but it will take months.

Sorry, suppose this workaround may stay with you for months 😉 I found vladar's workaround very elegant and don't see any problems.

vladar added a commit that referenced this pull request Feb 28, 2021
* fix(gatsby): workaround graphql-compose issue

* freeze after building

(cherry picked from commit 7f9bcf1)
vladar added a commit that referenced this pull request Feb 28, 2021
* fix(gatsby): workaround graphql-compose issue

* freeze after building

(cherry picked from commit 7f9bcf1)

Co-authored-by: Vladimir Razuvaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: GraphQL Related to Gatsby's GraphQL layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants