Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby): Add directory to GatsbyCacheLmdb #32391

Merged
merged 4 commits into from
Jul 19, 2021
Merged

fix(gatsby): Add directory to GatsbyCacheLmdb #32391

merged 4 commits into from
Jul 19, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jul 16, 2021 •
edited
Loading

Description

MDX plugin uses cache.directory to write stuff

Same as:

gatsby/packages/gatsby/src/utils/cache.ts

Line 29 in 79b7b04

this.directory = path.join(process.cwd(), `.cache/caches/${name}`)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 16, 2021
@LekoArts LekoArts added topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine) and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 16, 2021
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 19, 2021
@gatsbyjs gatsbyjs deleted a comment from gatsby-cloud bot Jul 19, 2021
pieh
pieh previously approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!

@pieh pieh dismissed their stale review July 19, 2021 09:01

dismissing after asking question

pieh
pieh approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!

@pieh pieh merged commit 7480849 into master Jul 19, 2021
@pieh pieh deleted the pqr/cache-directory-property branch July 19, 2021 11:10
LekoArts added a commit that referenced this pull request Jul 19, 2021
@LekoArts
fix(gatsby): Add directory to GatsbyCacheLmdb (#32391)
6821eef 
* initial

* Update cache-lmdb.ts

* add init to make sure caches dir is created

Co-authored-by: gatsbybot <[email protected]>
(cherry picked from commit 7480849)
@gatsbybot gatsbybot mentioned this pull request Jul 19, 2021
Merged
LekoArts added a commit that referenced this pull request Jul 19, 2021
@LekoArts
fix(gatsby): Add directory to GatsbyCacheLmdb (#32391) (#32421)
3d5bf37 
Co-authored-by: gatsbybot <[email protected]>
Co-authored-by: Lennart <[email protected]>
This was referenced Oct 1, 2023
Open
Open
Open
Open
Open
Open
Open
Open
@kaocher82 kaocher82 mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
topic: core Relates to Gatsby's core (e.g. page loading, reporter, state machine)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LekoArts @pieh