Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): restore onPreBuild to being called right after bootstrap finishes #33591

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

KyleAMathews
Copy link
Contributor

Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild

… finishes

Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 19, 2021
@KyleAMathews KyleAMathews added type: bug An issue or pull request relating to a bug in Gatsby and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 19, 2021
@wardpeet
Copy link
Contributor

The reason why I moved it lower was because it originally happened after query running so I moved it down as well. I'm not really opiniated about it so i'm fine with changing it, just giving context

@vladar vladar merged commit 4761dc3 into master Oct 19, 2021
@vladar vladar deleted the KyleAMathews-patch-1 branch October 19, 2021 13:19
@KyleAMathews
Copy link
Contributor Author

I was looking at git blame and it seemed to have been moved during the services refactor. Looking back earlier it was placed right after bootstrap then too.

wardpeet pushed a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
… finishes (gatsbyjs#33591)

* fix(gatsby): restore onPreBuild to being called right after bootstrap finishes

Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild

* chore: format

Co-authored-by: gatsbybot <[email protected]>
axe312ger pushed a commit that referenced this pull request Nov 9, 2021
… finishes (#33591)

* fix(gatsby): restore onPreBuild to being called right after bootstrap finishes

Somehow it drifted down in the build where it's supposed to be the first API called after bootstrap finishes https://www.gatsbyjs.com/docs/reference/config-files/gatsby-node/#onPreBuild

* chore: format

Co-authored-by: gatsbybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug in Gatsby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants