Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Move loadable-components instructions #35116

Merged
merged 3 commits into from
Mar 23, 2022
Merged

chore(docs): Move loadable-components instructions #35116

merged 3 commits into from
Mar 23, 2022

Conversation

Aviatorscode2
Copy link

@Aviatorscode2 Aviatorscode2 commented Mar 12, 2022 •
edited by LekoArts
Loading

Description

  1. I added an additional description to the onCreateWebpackConfig documentation section.
  2. Swapped walkthroughs 3 and 4. Using React's native method example should come before the example of the loadable components.
    Cc: @PaulieScanlon

@Aviatorscode2
onCreateWebpackConfiq
43d77d5 
I added an additional description to the onCreateWebpackConfig section.
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 12, 2022
@Aviatorscode2
Using Client-Side Only Package:
1eb7fe9 
Swapped walkthroughs 3 and 4. Using React's native method example should come before the example of the loadable components.
@Aviatorscode2 Aviatorscode2 changed the title onCreateWebpackConfiq onCreateWebpackConfiq and Using Client-Side Only Packages Mar 12, 2022
@LekoArts LekoArts changed the title onCreateWebpackConfiq and Using Client-Side Only Packages chore(docs): Move loadable-components instructions Mar 23, 2022
@LekoArts LekoArts added type: documentation An issue or pull request for improving or updating Gatsby's documentation and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 23, 2022
LekoArts
LekoArts approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LekoArts LekoArts merged commit 6454eed into gatsbyjs:master Mar 23, 2022
This was referenced Mar 29, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aviatorscode2 @LekoArts