Replace tools/code_check.sh with 'make codecheck'

[adlarkin]

With the new ign-cmake release coming out (2.6.0 - gazebosim/gz-cmake#131), we should run make codecheck in GitHub actions instead of running tools/code_check.sh so that we can make sure users are adhering to the new code checker introduced in gazebosim/gz-cmake#117.

I haven't tested this locally because I'm not sure how to, since it's a change for GitHub actions... does anyone know how to test this/would anyone be willing to test this?

Also, once this is merged and ign-cmake-2.6.0 is released, we will need to update all affected repositories to make sure that CI isn't broken due to being unable to pass make codecheck in GitHub actions (most repositories were already updated a few weeks ago in anticipation for this ign-cmake release, but I'm sure changes have been made to these repositories since things were updated a few weeks ago).

Signed-off-by: Ashton Larkin [email protected]

[chapulina]

does anyone know how to test this/would anyone be willing to test this?

You can create a branch on any Ignition library and update actions to use this branch, for example:

https:/ignitionrobotics/ign-plugin/blob/4a87904ac0b70385d8e5bb520e84ab11aa2eaba5/.github/workflows/ci.yml#L14

Actions will be triggered on push, so you can see the results on that commit and don't need to open a PR.

once this is merged and ign-cmake-2.6.0 is released

It's already out 😉 http://packages.osrfoundation.org/gazebo/ubuntu-stable/pool/main/i/ignition-cmake2/

we will need to update all affected repositories

Yup, but you did a good push on this a while back, right? So I think we may be able to just get this in and deal with the fallout? 😏

[adlarkin]

I went ahead and ran a few tests in ign-math (which should use make codecheck) and ign-tools (which should use tools/code_check.sh). The following test cases behaved as expected:

1. Default branch of ign-tools (ign-tools1) should pass GitHub actions using tools/code_check.sh: https:/ignitionrobotics/ign-tools/runs/1532616226?check_suite_focus=true
2. Default branch of ign-math (ign-math6) should pass GitHub actions using make codecheck: https:/ignitionrobotics/ign-math/runs/1532618612
3. Default branch of ign-math should fail GitHub actions using make codecheck by adding a really long comment that doesn't adhere to the 80 character width limit: https:/ignitionrobotics/ign-math/runs/1532762475

So, unless anyone notices a test case that is missed, I think this is ready for review.

[chapulina]

Let's do this! I say we just pull the trigger and deal with the fallout, in case there's any. Otherwise we'll always be chasing a moving target, because there are PRs being merged after we fix the checker.

[scpeters]

I think make codecheck doesn't actually work for ign-cmake itself: gazebosim/gz-cmake#134