Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to use venvs for pip installations #78

Draft
wants to merge 6 commits into
base: noble
Choose a base branch
from
Draft

Change to use venvs for pip installations #78

wants to merge 6 commits into from

Conversation

j-rivero
Copy link
Contributor

Following up #77 (review)

azeey
azeey approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@j-rivero j-rivero mentioned this pull request Jul 30, 2024
Open
@j-rivero
Copy link
Contributor Author

Not merging this one as it is now since the colcon move to a venv is breaking the way of introducing python dependencies into the build mix. Note ad7e979. I think this is kind of broken since we rely on system packages. #79 + changes here is the probably the best way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @azeey