Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Dependencies Archive for ign-tools installs #704

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Deprecate Dependencies Archive for ign-tools installs #704

merged 2 commits into from
Apr 15, 2022

Conversation

methylDragon
Copy link
Contributor

See: #685

This fixes the issue where ignition-tools gets installed alongside ignition-tools2 for versions that use it.

Also, this is a partial deprecation of the dependencies_archive in general.

chapulina
chapulina approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be good to run the DSL once and run a test build just to make sure that the syntax is all good

@methylDragon methylDragon force-pushed the ch3/deprecate-dependencies_archive-for-ign-tools-installs branch 3 times, most recently from ba68285 to cebc0fc Compare April 15, 2022 00:20
@methylDragon
Fix syntax error
5cacc1c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the ch3/deprecate-dependencies_archive-for-ign-tools-installs branch from cebc0fc to 5cacc1c Compare April 15, 2022 00:21
@methylDragon
Copy link
Contributor Author

Green DSL generate: https://build.osrfoundation.org/job/_dsl_ignition_collection/500/
Successful build using the RTools branch: https://build.osrfoundation.org/job/ignition_msgs-ci-pr_any-ubuntu_auto-amd64/847/console

@methylDragon methylDragon merged commit ffd4858 into master Apr 15, 2022
@methylDragon methylDragon deleted the ch3/deprecate-dependencies_archive-for-ign-tools-installs branch April 15, 2022 00:32
@chapulina chapulina mentioned this pull request Apr 15, 2022
Merged
@j-rivero j-rivero mentioned this pull request Apr 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina