-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDF demo #31
SDF demo #31
Conversation
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mohamedsayed18 I left a partial review since there's quite a few comments. I'll let you address these first, and carry on the changes to the rest of the doc. I really like what you've done so far!
One thing I'd like to see is an outline of the sections - just the headings. something like:
# Title
## What is SDF?
## Breaking down the code
### The model
### Inertial properties
### Frames
## Conclusion
It's good to break a tutorial up into labeled sections as much as logically possible to help learners feel like they're progressing through a set of steps and not facing one huge task
Thank you for your detailed feedback, waiting for the rest of the readme. |
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestion on how to improve the vehicle SDF. The final vehicle I tested is here.
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did another pass and left some more comments 👍
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: maryaB-osr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some minor comments.
I just had an idea so the user can see something happening by the end of this tutorial. What do you think of making the ground plane slightly rotated so that in the end of the tutorial, we can tell the user to press "play" and they see the car rolling downhill?
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
Signed-off-by: mohamedsayed18 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some final tweaks to suggest and then I think this is ready to go in.
As I mentioned on chat, I also think we should rename this tutorial from car_demo
to some more descriptive name.
Signed-off-by: mohamedsayed18 <[email protected]>
No description provided.