Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak ros2_overview tutorial. #531

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Oct 22, 2024

🦟 Bug fix

This patch fixes one typo and the figure (the parameter values were wrong). Thanks @azeey for catching it.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 22, 2024
@caguero caguero requested a review from azeey October 22, 2024 13:58
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @caguero. One other thing I noticed on the image on the right is that it's not clear that Gazebo and the bridge are running in the same container and nav2 is running outside of that container. Could you add something to the graphics to group Gazebo and the bridge together?

@caguero
Copy link
Contributor Author

caguero commented Oct 22, 2024

Thanks @caguero. One other thing I noticed on the image on the right is that it's not clear that Gazebo and the bridge are running in the same container and nav2 is running outside of that container. Could you add something to the graphics to group Gazebo and the bridge together?

The intent of the right image is to show that the three nodes can be running within the same process. However, we're not starting the container ourselves..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants